Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'await' in front of eventrepository call #356

Merged
merged 7 commits into from
Nov 8, 2023
Merged

added 'await' in front of eventrepository call #356

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
498033a
added 'await' in front of eventrepository call
yimmyj Jun 8, 2023
8313d5c
deleted yarn.lock
yimmyj Jun 8, 2023
423aeb7
removed brewfile and extra line in package.json
yimmyj Jun 8, 2023
07d72b0
added yarn.lock back lols
yimmyj Jun 8, 2023
38e185b
removed yarn.lock
yimmyj Aug 11, 2023
678ac7d
removed yarn.lock file from gitignore, updated yarn.lock contents
yimmyj Oct 25, 2023
5e0b78d
Merge branch 'master' into Jimmy/fix-event-create-error-message
yimmyj Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/EventService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default class EventService {
public async create(event: Event): Promise<PublicEvent> {
const eventCreated = await this.transactions.readWrite(async (txn) => {
const eventRepository = Repositories.event(txn);
const isUnusedAttendanceCode = eventRepository.isUnusedAttendanceCode(event.attendanceCode);
const isUnusedAttendanceCode = await eventRepository.isUnusedAttendanceCode(event.attendanceCode);
if (!isUnusedAttendanceCode) throw new UserError('Attendance code has already been used');
if (event.start > event.end) throw new UserError('Start date after end date');
return eventRepository.upsertEvent(EventModel.create(event));
Expand Down