Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Auto Comment on PRs GitHub Action #375

Merged
merged 6 commits into from
Dec 3, 2023

Conversation

nik-dange
Copy link
Member

@nik-dange nik-dange commented Nov 13, 2023

Updates the GitHub Action that auto-comments on PRs cuz I think it's outdated. I believe it's this one: https://github.com/wow-actions/auto-comment

Also, do we want to change the message? I notice we haven't really been bumping up the package version in package.json for the past few months. Thoughts on if we should resume doing it?

Copy link

Thanks for contributing!
If you've made changes to the API's functionality, please make sure to bump the package
version—see this guide to semantic versioning for details—and
document those changes as appropriate.

@alexzhang1618
Copy link
Contributor

I think we should be updating the versioning in package.json, it's good practice and helps distinguish between changes.
For semver stuff, if the current version is X.Y.Z:

  • Updating to X.Y.Z+1 is a PATCH change that basically just fixes a bug and doesn't change much else
    • e.g. adding a missing await
  • Updating to X.Y+1.Z is a MINOR change that adds a new feature but is otherwise backwards compatible
    • e.g. adding admin management routes
  • Updating to X+1.Y.Z is a MAJOR change that has breaking changes for some functionalities
    • e.g. changing store images to be an array of multiple instead of one image, restructuring/removing store checkout routes, etc etc

An explanation like this could be added to the PR template or the workflow to remind people to update the versioning and also what each one is

@nik-dange nik-dange merged commit 0cf49fe into master Dec 3, 2023
2 checks passed
@nik-dange nik-dange deleted the nikhil/fix-autocomment-github-action branch February 29, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants