Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Example Env Variable Name Fix #388

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

dowhep
Copy link
Contributor

@dowhep dowhep commented Jan 20, 2024

Info

Closes [ISSUE NUMBER]. (If there is no issue for this pull request yet, please create one or
delete this line if the pull request is for a very minor tweak).

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.

I edited the example env file to make the variable names consistent

Changes

  • edited the variable names in the example env file

Type of Change

  • Patch (non-breaking change/bugfix)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (A change to a README/description)
  • Continuous Integration/DevOps Change (Related to deployment steps, continuous integration
    workflows, linting, etc.)
  • Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally.
  • on the testing API/testing database.
  • with appropriate Postman routes. Screenshots are included below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have appropriately edited the API version in the package.json file.
  • My changes produce no new warnings.

Screenshots

Please include a screenshot of your Postman testing passing successfully.

Copy link

Thanks for contributing!
If you've made changes to the API's functionality, please make sure to bump the package
version—see this guide to semantic versioning for details—and
document those changes as appropriate.

@dowhep dowhep changed the title fix merch photo env vars Quick Example Env Variable Name Fix Jan 20, 2024
Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 PR ACCEPTED! 🎊 Your feature is like a shooting star in our code galaxy. ⭐️ Thanks for the stellar contribution! 🚀 Keep shining bright! ✨

@dowhep dowhep merged commit 98c266c into master Jan 20, 2024
5 checks passed
@dowhep dowhep deleted the bug/fix-example-env-variable-name branch January 20, 2024 22:06
@dowhep dowhep restored the bug/fix-example-env-variable-name branch January 20, 2024 22:06
@dowhep dowhep deleted the bug/fix-example-env-variable-name branch January 20, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants