Refactor MerchStoreService + Misc. Bug Fixes #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-dange
requested review from
sumeet-bansal,
shravanhariharan2 and
dowhep
as code owners
|
Thanks for contributing! |
maxwn04
reviewed
May 1, 2024
| this.emailService = emailService; | ||
| } | ||
|
|
||
| public async findItemByUuid(uuid: Uuid, user: UserModel): Promise<PublicMerchItemWithPurchaseLimits> { |
There was a problem hiding this comment.
Inconsistent external vs internal types, service returning a public type
…into feature/merch-store-refactor merging from master
dowhep
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
Closes #200.
Description
The MerchStoreService contains logic for both Merch Store functionality as well as Merch Order functionality. Refactoring into a
MerchStoreServiceand aMerchOrderServicefor ease of development moving forward. Also random bug fixes.Changes
MerchOrderServiceType of Change
expected)
workflows, linting, etc.)
If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in
package.json!Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
package.jsonfile.Screenshots
Please include a screenshot of your Postman testing passing successfully.