Update Remote Docker config on CircleCI #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-dange
requested review from
sumeet-bansal,
shravanhariharan2 and
dowhep
as code owners
|
Thanks for contributing! |
|
Tested on staging: Old Remote Docker step on CircleCI: 
New Remote Docker step on CircleCI: 
|
maxwn04
added a commit
that referenced
this pull request
Sep 28, 2024
* refactored into merchorderservice * some more refactoring * everything except one test * fixed full check * linting * Update Remote Docker config on CircleCI (#445) * updated to docker24 (latest stable v) * docker24 as remote docker version * Remove Sumeet from CODEOWNERS (#447) cleaning up my reviews request tab :) * Remove branch message --------- Co-authored-by: Nikhil Dange <[email protected]> Co-authored-by: Sumeet Bansal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.
Various remote Docker configs on CircleCI are being deprecated. There's a few brownout periods scheduled for next week, with EOL approaching September 2024.
See relevant links for context:
https://support.circleci.com/hc/en-us/articles/23614965074459-2024-Image-Deprecations-and-Brownouts-Android-Linux-VM-Remote-Docker-Linux-VM
https://discuss.circleci.com/t/remote-docker-image-deprecations-and-eol-for-2024/50176?utm_medium=email&_hsenc=p2ANqtz-9P46ZxrakdBmjjv6vTaht8ITewtk4HQGu-4CC2utgZiEzLcoBG0GpFuODxUKOtdbYpgjPkARzMxDGw9uYk9qGRf831Yg&_hsmi=308450229&utm_content=308450229&utm_source=hs_email
Changes
Type of Change
expected)
workflows, linting, etc.)
If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in
package.json!Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
package.jsonfile.Screenshots
Please include a screenshot of your Postman testing passing successfully.