Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-3442: Automation with modules development branch #1724

Merged
merged 11 commits into from
Jan 30, 2024
Merged

Conversation

rajeshreeputra
Copy link
Contributor

@rajeshreeputra rajeshreeputra commented Jan 17, 2024

Motivation
Fixes #ACMS-3442

Proposed changes
Execute CI job with development version of Drupal.Org modules.

Alternatives considered
NA
Note: After the review is successfully completed, the job will be removed from the CI and available only for CRON.

Testing steps
Follow from Ticket.

Merge requirements

  • Major change, Minor change, Bug, Enhancement, and/or Chore label applied
  • Manual testing by a reviewer

@rajeshreeputra rajeshreeputra force-pushed the ACMS-3442 branch 15 times, most recently from 8a20630 to 54b05e8 Compare January 18, 2024 08:23
@rajeshreeputra rajeshreeputra marked this pull request as ready for review January 18, 2024 08:28
@chandan-singh7929
Copy link
Collaborator

Please resolve the conflict.

@rajeshreeputra rajeshreeputra force-pushed the ACMS-3442 branch 3 times, most recently from bf18b64 to 2e701a5 Compare January 23, 2024 06:18
Copy link
Collaborator

@chandan-singh7929 chandan-singh7929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes looks good me, just few suggestions:

  • This job should run on CRON
  • We should implement slack notification on failure.

@rajeshreeputra rajeshreeputra force-pushed the ACMS-3442 branch 3 times, most recently from 7b16702 to 538dca8 Compare January 25, 2024 10:35
@rajeshreeputra rajeshreeputra force-pushed the ACMS-3442 branch 8 times, most recently from 1aa0e1c to 8e257f8 Compare January 25, 2024 12:55
@rajeshreeputra rajeshreeputra force-pushed the ACMS-3442 branch 3 times, most recently from 9e585af to 687ed19 Compare January 29, 2024 16:39
@vishalkhode1 vishalkhode1 merged commit 5d0c440 into develop Jan 30, 2024
17 checks passed
@vishalkhode1 vishalkhode1 deleted the ACMS-3442 branch January 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants