-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACMS-3442: Automation with modules development branch #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a20630
to
54b05e8
Compare
apathak18
approved these changes
Jan 18, 2024
Please resolve the conflict. |
bf18b64
to
2e701a5
Compare
chandan-singh7929
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes looks good me, just few suggestions:
- This job should run on CRON
- We should implement slack notification on failure.
7b16702
to
538dca8
Compare
1aa0e1c
to
8e257f8
Compare
9e585af
to
687ed19
Compare
687ed19
to
f35bb00
Compare
vishalkhode1
approved these changes
Jan 30, 2024
vishalkhode1
requested changes
Jan 30, 2024
Co-authored-by: Vishal Khode <[email protected]>
vishalkhode1
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #ACMS-3442
Proposed changes
Execute CI job with development version of Drupal.Org modules.
Alternatives considered
NA
Note: After the review is successfully completed, the job will be removed from the CI and available only for CRON.
Testing steps
Follow from Ticket.
Merge requirements