CLI-1192: Symfony 6.3.4 breaks checklists (#1766)

* CLI-1192: Update symfony/console

* Fix spinner

* kill mutant

composer.json

@@ -34,7 +34,7 @@
         "react/event-loop": "^1.1",
         "symfony/cache": "^6.3",
         "symfony/config": "^6.3",
-        "symfony/console": "6.3.2",
+        "symfony/console": "^6.3",
         "symfony/dependency-injection": "^6.3",
         "symfony/dotenv": "^6.3",
         "symfony/event-dispatcher": "^6.3",

src/Output/Checklist.php

@@ -44,7 +44,7 @@ public function completePreviousItem(): void
             $item = $this->getLastItem();
             /** @var \Acquia\Cli\Output\Spinner\Spinner $spinner */
             $spinner = $item['spinner'];
-            $spinner->setMessage('', 'detail');
+            $spinner->setMessage(' ', 'detail');
             $spinner->setMessage($item['message']);
             $spinner->advance();
             $spinner->finish();

src/Output/Spinner/Spinner.php

@@ -105,7 +105,7 @@ public function __construct(private OutputInterface $output, private int $indent
         $this->progressBar->setEmptyBarCharacter('⌛');
         $this->progressBar->setFormat($indentString . "%bar% %message%\n%detail%");
         $this->progressBar->setBarWidth(1);
-        $this->progressBar->setMessage('', 'detail');
+        $this->progressBar->setMessage(' ', 'detail');
         $this->progressBar->setOverwrite($output->getVerbosity() < OutputInterface::VERBOSITY_VERBOSE);
     }
 

tests/phpunit/src/Commands/ChecklistTest.php → tests/phpunit/src/Misc/ChecklistTest.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Acquia\Cli\Tests\Commands;
+namespace Acquia\Cli\Tests\Misc;
 
 use Acquia\Cli\Output\Checklist;
 use Acquia\Cli\Tests\TestBase;
@@ -28,6 +28,9 @@ public function testSpinner(): void
         putenv('PHPUNIT_RUNNING=1');
         $checklist = new Checklist($this->output);
         $checklist->addItem('Testing!');
+        $items = $checklist->getItems();
+        $progressBar = $items[0]['spinner']->getProgressBar();
+        $this->assertEquals(' ', $progressBar->getMessage('detail'));
 
         // Make the spinner spin with some output.
         $outputCallback = static function (string $type, string $buffer) use ($checklist): void {
@@ -48,7 +51,7 @@ public function testSpinner(): void
         $this->assertEquals('⢸', $progressBar->getProgressCharacter());
         $this->assertEquals('⌛', $progressBar->getEmptyBarCharacter());
         $this->assertEquals(1, $progressBar->getBarWidth());
-        $this->assertEquals('', $progressBar->getMessage('detail'));
+        $this->assertEquals(' ', $progressBar->getMessage('detail'));
 
         putenv('PHPUNIT_RUNNING');
     }