fix tests

acquia · Nov 14, 2024 · 3551105 · 3551105
1 parent efd491f
commit 3551105
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/src/Command/App/LogTailCommand.php b/src/Command/App/LogTailCommand.php
@@ -54,7 +54,7 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $environment = $this->determineEnvironment($input, $output, true);
+        $environment = $this->determineEnvironment($input, $output);
         $acquiaCloudClient = $this->cloudApiClientService->getClient();
         $logs = $this->promptChooseLogs();
         $logTypes = array_map(static function (mixed $log) {

diff --git a/src/Command/Email/ConfigurePlatformEmailCommand.php b/src/Command/Email/ConfigurePlatformEmailCommand.php
@@ -225,7 +225,7 @@ private function addDomainToSubscriptionApplications(Client $client, Subscriptio
     /**
      * Validates the URL entered as the base domain name.
      */
-    public static function validateUrl(?string $url): string
+    protected static function validateUrl(?string $url): string
     {
         $constraintsList = [new NotBlank()];
         $urlParts = parse_url($url);

diff --git a/src/Command/Remote/DrushCommand.php b/src/Command/Remote/DrushCommand.php
@@ -36,7 +36,7 @@ protected function configure(): void
      */
     protected function execute(InputInterface $input, OutputInterface $output): ?int
     {
-        $environment = $this->determineEnvironment($input, $output, true);
+        $environment = $this->determineEnvironment($input, $output);
         $alias = self::getEnvironmentAlias($environment);
         $acliArguments = $input->getArguments();
         $drushArguments = (array) $acliArguments['drush_command'];

diff --git a/tests/phpunit/src/Commands/Acsf/AcsfAuthLoginCommandTest.php b/tests/phpunit/src/Commands/Acsf/AcsfAuthLoginCommandTest.php
@@ -9,6 +9,7 @@
 use Acquia\Cli\Command\CommandBase;
 use Acquia\Cli\Config\CloudDataConfig;
 use Acquia\Cli\DataStore\CloudDataStore;
+use Symfony\Component\Console\Exception\MissingInputException;
 use Symfony\Component\Validator\Exception\ValidatorException;
 
 /**
@@ -151,6 +152,16 @@ public function testAcsfAuthLoginInvalid(array $args, string $message): void
         $this->executeCommand($args);
     }
 
+    public function testAcsfAuthLoginInvalidInput(): void
+    {
+        $this->removeMockCloudConfigFile();
+        $this->createMockCloudConfigFile(AcsfCommandTestBase::getAcsfCredentialsFileContents());
+        $this->createDataStores();
+        $this->command = $this->createCommand();
+        $this->expectException(MissingInputException::class);
+        $this->executeCommand([], ['n', 'Enter a new factory URL', 'example.com']);
+    }
+
     protected function assertKeySavedCorrectly(): void
     {
         $credsFile = $this->cloudConfigFilepath;