Skip to content

Commit

Permalink
CLI-1292: Catch Cloud API type errors
Browse files Browse the repository at this point in the history
  • Loading branch information
@danepowell
danepowell committed Mar 13, 2024
1 parent bda9ffa commit 807b79e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/EventListener/ExceptionListener.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ public function onConsoleError(ConsoleErrorEvent $event): void {
}
}

if ($error instanceof \TypeError && str_contains($error->getMessage(), 'AcquiaCloudApi\Response')) {

Check warning on line 82 in src/EventListener/ExceptionListener.php

View workflow job for this annotation

GitHub Actions / Mutation Testing 

Escaped Mutant for Mutator "InstanceOf_":

--- Original
+++ New
@@ @@
                     $this->helpMessages[] = "You can learn more about Cloud Platform API at https://docs.acquia.com/cloud-platform/develop/api/";
             }
         }
-        if ($error instanceof \TypeError && str_contains($error->getMessage(), 'AcquiaCloudApi\\Response')) {
+        if (false && str_contains($error->getMessage(), 'AcquiaCloudApi\\Response')) {
             $newErrorMessage = 'Cloud API returned an unexpected data type; this could indicate a problem with your Cloud application.';
         }
         $this->helpMessages[] = "You can find Acquia CLI documentation at https://docs.acquia.com/acquia-cli/";

Check warning on line 82 in src/EventListener/ExceptionListener.php

View workflow job for this annotation

GitHub Actions / Mutation Testing 

Escaped Mutant for Mutator "InstanceOf_":

--- Original
+++ New
@@ @@
                     $this->helpMessages[] = "You can learn more about Cloud Platform API at https://docs.acquia.com/cloud-platform/develop/api/";
             }
         }
-        if ($error instanceof \TypeError && str_contains($error->getMessage(), 'AcquiaCloudApi\\Response')) {
+        if (true && str_contains($error->getMessage(), 'AcquiaCloudApi\\Response')) {
             $newErrorMessage = 'Cloud API returned an unexpected data type; this could indicate a problem with your Cloud application.';
         }
         $this->helpMessages[] = "You can find Acquia CLI documentation at https://docs.acquia.com/acquia-cli/";

Check warning on line 82 in src/EventListener/ExceptionListener.php

View workflow job for this annotation

GitHub Actions / Mutation Testing 

Escaped Mutant for Mutator "LogicalAnd":

--- Original
+++ New
@@ @@
                     $this->helpMessages[] = "You can learn more about Cloud Platform API at https://docs.acquia.com/cloud-platform/develop/api/";
             }
         }
-        if ($error instanceof \TypeError && str_contains($error->getMessage(), 'AcquiaCloudApi\\Response')) {
+        if ($error instanceof \TypeError || str_contains($error->getMessage(), 'AcquiaCloudApi\\Response')) {
             $newErrorMessage = 'Cloud API returned an unexpected data type; this could indicate a problem with your Cloud application.';
         }
         $this->helpMessages[] = "You can find Acquia CLI documentation at https://docs.acquia.com/acquia-cli/";

Check warning on line 82 in src/EventListener/ExceptionListener.php

View workflow job for this annotation

GitHub Actions / Mutation Testing 

Escaped Mutant for Mutator "LogicalAndAllSubExprNegation":

--- Original
+++ New
@@ @@
                     $this->helpMessages[] = "You can learn more about Cloud Platform API at https://docs.acquia.com/cloud-platform/develop/api/";
             }
         }
-        if ($error instanceof \TypeError && str_contains($error->getMessage(), 'AcquiaCloudApi\\Response')) {
+        if (!$error instanceof \TypeError && !str_contains($error->getMessage(), 'AcquiaCloudApi\\Response')) {
             $newErrorMessage = 'Cloud API returned an unexpected data type; this could indicate a problem with your Cloud application.';
         }
         $this->helpMessages[] = "You can find Acquia CLI documentation at https://docs.acquia.com/acquia-cli/";

Check warning on line 82 in src/EventListener/ExceptionListener.php

View workflow job for this annotation

GitHub Actions / Mutation Testing 

Escaped Mutant for Mutator "LogicalAndSingleSubExprNegation":

--- Original
+++ New
@@ @@
                     $this->helpMessages[] = "You can learn more about Cloud Platform API at https://docs.acquia.com/cloud-platform/develop/api/";
             }
         }
-        if ($error instanceof \TypeError && str_contains($error->getMessage(), 'AcquiaCloudApi\\Response')) {
+        if ($error instanceof \TypeError && !str_contains($error->getMessage(), 'AcquiaCloudApi\\Response')) {
             $newErrorMessage = 'Cloud API returned an unexpected data type; this could indicate a problem with your Cloud application.';
         }
         $this->helpMessages[] = "You can find Acquia CLI documentation at https://docs.acquia.com/acquia-cli/";

Check warning on line 82 in src/EventListener/ExceptionListener.php

View workflow job for this annotation

GitHub Actions / Mutation Testing 

Escaped Mutant for Mutator "LogicalAndNegation":

--- Original
+++ New
@@ @@
                     $this->helpMessages[] = "You can learn more about Cloud Platform API at https://docs.acquia.com/cloud-platform/develop/api/";
             }
         }
-        if ($error instanceof \TypeError && str_contains($error->getMessage(), 'AcquiaCloudApi\\Response')) {
+        if (!($error instanceof \TypeError && str_contains($error->getMessage(), 'AcquiaCloudApi\\Response'))) {
             $newErrorMessage = 'Cloud API returned an unexpected data type; this could indicate a problem with your Cloud application.';
         }
         $this->helpMessages[] = "You can find Acquia CLI documentation at https://docs.acquia.com/acquia-cli/";
$newErrorMessage = 'Cloud API returned an unexpected data type; this could indicate a problem with your Cloud application.';

Check warning on line 83 in src/EventListener/ExceptionListener.php

View check run for this annotation

Codecov / codecov/patch

src/EventListener/ExceptionListener.php#L83 

Added line #L83 was not covered by tests
}

$this->helpMessages[] = "You can find Acquia CLI documentation at https://docs.acquia.com/acquia-cli/";
$this->writeUpdateHelp($event);
$this->writeSupportTicketHelp($event);
Expand Down

0 comments on commit 807b79e

Please sign in to comment.