Added prompt for php version for cs:wizard command #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. Dane returns in mid-October. We'll look into finalizing and merging this then. Continue fixing tests and getting this as ready as can be in the interim! |
bemarlan
suggested changes
Sep 22, 2023
bemarlan
reviewed
Sep 22, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1594 +/- ##
============================================
- Coverage 91.76% 91.68% -0.08%
Complexity 1809 1809
============================================
Files 124 124
Lines 6471 6485 +14
============================================
+ Hits 5938 5946 +8
- Misses 533 539 +6
☔ View full report in Codecov by Sentry. |
shubham-bansal96
changed the title
bemarlan
approved these changes
Sep 26, 2023
shriacquia
approved these changes
Sep 28, 2023
bemarlan
reviewed
Sep 28, 2023
tests/phpunit/src/Commands/CodeStudio/CodeStudioWizardCommandTest.php
Outdated
Show resolved
Hide resolved
bemarlan
reviewed
Sep 28, 2023
danepowell
reviewed
Oct 17, 2023
| @@ -46,6 +46,15 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| // But, we specifically need an API Token key-pair of Code Studio. | |||
| // So we reauthenticate to be sure we're using the provided credentials. | |||
| $this->reAuthenticate($cloudKey, $cloudSecret, $this->cloudCredentials->getBaseUri(), $this->cloudCredentials->getAccountsUri()); | |||
|
|
|||
| $phpVersions = [ | |||
| 'PHP_version_8.1' => "8.1", | |||
There was a problem hiding this comment.
Yuck. Did you pick these array keys because PHPCS was complaining or something?
|
Thanks, this mostly looks good. Just FYI, you could kill some of the mutants by improving the test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes # GL-1836
Proposed changes
Add a prompt to choose php version between two of them. Either 8.1 or 8.2
Alternatives considered
Testing steps
run command
./bin/acli cs:wizardand CLI should ask to choose PHP version. Once steps are completed then verify PHP_VERSION variable should get added to code studio UI../bin/acli ckc