Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1168: Improve Dockerfile #1618

Merged
merged 1 commit into from
Oct 30, 2023
Merged

CLI-1168: Improve Dockerfile #1618

merged 1 commit into from
Oct 30, 2023

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Oct 30, 2023

This switches the base image to php-alpine, reducing build times, and adds an init script to make it easier to run.

An experimental build is on Dockerhub: https://hub.docker.com/repository/docker/acquia/cli

This pattern is based loosely on the Composer Docker image: https://github.com/composer/docker

If this catches on, we should make a few improvements:

  • set up autobuilds on Dockerhub
  • move the Docker files to their own repo, add a proper README
  • update install docs on docs.acquia.com
  • implement the xdg standards to allow moving the Acquia config directory out of /root.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45b30b9) 91.83% compared to head (791347d) 91.83%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1618   +/-   ##
=========================================
  Coverage     91.83%   91.83%           
  Complexity     1816     1816           
=========================================
  Files           124      124           
  Lines          6505     6505           
=========================================
  Hits           5974     5974           
  Misses          531      531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell merged commit b1a1914 into acquia:main Oct 30, 2023
13 checks passed
@danepowell danepowell deleted the CLI-1168 branch September 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant