Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1151: Support PHP 8.3 #1622

Merged
merged 2 commits into from
Nov 2, 2023
Merged

CLI-1151: Support PHP 8.3 #1622

merged 2 commits into from
Nov 2, 2023

Conversation

danepowell
Copy link
Contributor

Motivation

Fixes #NNN

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (141468f) 91.84% compared to head (2efd354) 91.84%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1622   +/-   ##
=========================================
  Coverage     91.84%   91.84%           
  Complexity     1819     1819           
=========================================
  Files           124      124           
  Lines          6514     6514           
=========================================
  Hits           5983     5983           
  Misses          531      531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell merged commit b0457a7 into acquia:main Nov 2, 2023
12 checks passed
@anavarre anavarre changed the title CLI-1151: Support PHP 8.3 and 8.4 CLI-1151: Support PHP 8.3 Nov 8, 2023
@danepowell danepowell deleted the CLI-1151 branch September 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant