Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1186: push:artifact fails if empty directory exists #1625

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell added the bug Something isn't working label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbdc845) 91.84% compared to head (094c624) 91.84%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1625   +/-   ##
=========================================
  Coverage     91.84%   91.84%           
  Complexity     1819     1819           
=========================================
  Files           124      124           
  Lines          6514     6515    +1     
=========================================
+ Hits           5983     5984    +1     
  Misses          531      531           
Files Coverage Δ
src/Command/Push/PushArtifactCommand.php 91.51% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell requested a review from mglaman November 7, 2023 18:16
Copy link
Contributor

@mglaman mglaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me!

@danepowell danepowell merged commit b4108ba into acquia:main Nov 8, 2023
14 checks passed
@danepowell danepowell deleted the CLI-1186 branch September 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants