Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1175: [auth:acsf-logout] undefined array key #1631

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

danepowell
Copy link
Contributor

cloudApiClientService should be an instance of AcsfClientService but it's not. I can't figure out how to wire up the service container to make that work.

It's easy enough to do without it though.

@danepowell danepowell added the bug Something isn't working label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7f044a2) 91.83% compared to head (b0d9e72) 91.93%.

❗ Current head b0d9e72 differs from pull request most recent head 3be9805. Consider uploading reports for the commit 3be9805 to get more accurate results

Files Patch % Lines
src/Command/App/NewFromDrupal7Command.php 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1631      +/-   ##
============================================
+ Coverage     91.83%   91.93%   +0.09%     
+ Complexity     1820     1819       -1     
============================================
  Files           124      124              
  Lines          6516     6509       -7     
============================================
  Hits           5984     5984              
+ Misses          532      525       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell merged commit 7aa3083 into acquia:main Nov 13, 2023
24 checks passed
@danepowell danepowell deleted the CLI-1175 branch September 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant