Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1217: push:artifact should infer app id from env id #1633

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

danepowell
Copy link
Contributor

Motivation

I was trying to deploy code from a repo to a new application not already linked to that repo and was confused when it produced a Cloud API error because it was inferring the app id from .acquia-cli.yml rather than the more explicit env id.

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79d271c) 91.93% compared to head (bdf9f5f) 91.93%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1633   +/-   ##
=========================================
  Coverage     91.93%   91.93%           
- Complexity     1819     1821    +2     
=========================================
  Files           124      124           
  Lines          6509     6513    +4     
=========================================
+ Hits           5984     5988    +4     
  Misses          525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell merged commit b839f67 into acquia:main Nov 16, 2023
14 checks passed
@danepowell danepowell deleted the CLI-1217 branch September 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant