Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1210: Drop tables instead of database #1638

Merged
merged 4 commits into from
Nov 28, 2023
Merged

CLI-1210: Drop tables instead of database #1638

merged 4 commits into from
Nov 28, 2023

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Nov 22, 2023

Fixes #1629
Fixes #1634

Note, this has the side effect of no longer creating a db if it doesn't already exist.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (928c361) 91.80% compared to head (41caf77) 91.81%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1638      +/-   ##
============================================
+ Coverage     91.80%   91.81%   +0.01%     
- Complexity     1776     1778       +2     
============================================
  Files           122      122              
  Lines          6381     6390       +9     
============================================
+ Hits           5858     5867       +9     
  Misses          523      523              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell
Copy link
Contributor Author

I'm fine with this approach since it de-escalates the required permissions for these operations, which is always good. Cloud IDE should still work fine since required DBs are created via cron. Not sure about Lando.

@danepowell danepowell marked this pull request as ready for review November 28, 2023 19:09
@danepowell danepowell enabled auto-merge (squash) November 28, 2023 19:09
@github-actions github-actions bot added the bug Something isn't working label Nov 28, 2023
@danepowell danepowell merged commit 218c676 into main Nov 28, 2023
20 checks passed
@danepowell danepowell deleted the CLI-1210 branch September 20, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement
Projects
None yet
1 participant