Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1226: Support objects as API params #1646

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Dec 8, 2023

Some of the cleanup is due to the api/acsf api specs getting cleaned up themselves: DG-26039 / #1022

@danepowell danepowell added the bug Something isn't working label Dec 8, 2023
@danepowell danepowell requested a review from eporama December 8, 2023 17:52
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc786c9) 91.60% compared to head (9eb5b90) 91.60%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1646   +/-   ##
=========================================
  Coverage     91.60%   91.60%           
+ Complexity     1782     1778    -4     
=========================================
  Files           122      122           
  Lines          6410     6400   -10     
=========================================
- Hits           5872     5863    -9     
+ Misses          538      537    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell marked this pull request as ready for review December 8, 2023 17:54
@danepowell danepowell merged commit 835f643 into acquia:main Dec 11, 2023
4 checks passed
@danepowell danepowell deleted the CLI-1226 branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant