Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new command to encrypt the variable like in pipeline. #1662

Closed

Conversation

joshirohit100
Copy link
Contributor

@joshirohit100 joshirohit100 commented Jan 13, 2024

Issue - https://github.com/acquia/cli/issues/1661

New Command -

./bin/acli pipeline:encrypt-var texttoencrypt
./bin/acli pipeline:encrypt-var --help
Description:
  Get the encrypted text to be used for pipeline

Usage:
  pipeline:encrypt-var <encrypting_string> <applicationUuid>
  pipeline:encrypt-var SOMESTRINGTOENCRYPT APPUUIDHERE

Arguments:
  encrypting_string     Text that to be encrypted
  applicationUuid       The Cloud Platform application UUID or alias (i.e. an application name optionally prefixed with the realm)

something same which is provided by pipeline client encrypt command

@joshirohit100
Copy link
Contributor Author

If this is fine (approved), will add the tests

@danepowell
Copy link
Contributor

danepowell commented Jan 23, 2024

Why not just use the Pipeline CLI for this? I'm not happy about the idea of duplicating functionality between Acquia CLI and Pipeline CLI piecemeal. If we're going to merge Pipeline CLI into Acquia CLI, it needs to be part of a coordinated effort.

If this is important to you, let me know as we'll need to create spike ticket and figure out how to prioritize it.

@danepowell
Copy link
Contributor

Our original vision was to eventually migrate all of the code in Pipeline CLI into Acquia CLI. I no longer think that's feasible since there's just so much of it.

This command is minimal by comparison because it's missing a lot of features of Pipeline CLI such as input validation, the ability to set custom endpoints, etc

Basically, this sets a precedent for the migration of a limited set of features from Pipeline CLI rather than the whole kit and kaboodle.

I'm okay with that but I want to see if @anavarre agrees. My worry is that the sort-of-but-not-quite duplication of functionality between Pipeline CLI and Acquia CLI will create confusion for customers. On the other hand, I think this migration can only ever happen in this piecemeal fashion, and there is value in deprecating Pipeline CLI.

@anavarre
Copy link
Contributor

Yes, I'm afraid we don't want to set this precedent. Whatever relates to Pipelines CLI needs to be developed there until we hypothetically decide to merge both CLI together. The separation of concern is important IMHO.

@danepowell
Copy link
Contributor

Sorry @joshirohit100 , I'm afraid we can't accept this.

@danepowell danepowell closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants