Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1256: Update ACSF API spec #1667

Merged
merged 3 commits into from
Jan 26, 2024
Merged

CLI-1256: Update ACSF API spec #1667

merged 3 commits into from
Jan 26, 2024

Conversation

danepowell
Copy link
Contributor

Motivation

The ACSF API spec is out of date, leading to some endpoints and options being missing.

Proposed changes

Update the spec

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Run acli acsf:list, see all endpoints available
  4. Run acli help acsf:stage-v2:start, see force flag available
  5. Spot check an ACLI command

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0fc725f) 91.32% compared to head (eaa2229) 91.32%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1667   +/-   ##
=========================================
  Coverage     91.32%   91.32%           
  Complexity     1786     1786           
=========================================
  Files           122      122           
  Lines          6435     6435           
=========================================
  Hits           5877     5877           
  Misses          558      558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell merged commit 6fc3f53 into acquia:main Jan 26, 2024
12 checks passed
@danepowell danepowell deleted the CLI-1256 branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant