Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm frequently discouraged from adding new commands if they would require adding a new dependency to the service container, since this requires adding the dependency to our already-massive CommandBase constructor as well as all the places its invoked. This is a pain to maintain.
And of course, there are performance considerations in building a service container with every possible dependency for every possible command every time the application is run.
It would be a lot better to only inject the dependencies necessary for a specific command when that command is run. This PR sets a precedent for that pattern and makes some progress by removing the Guzzle Client and Logstream Manager as base dependencies.
I'd really love to kill the CommandBase entirely, but I haven't figured out how to handle dependencies that are universal or nearly-universal, such as the Telemetry and Credentials helpers.