Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1263: [ide:share] remove unnecessary API call #1689

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

danepowell
Copy link
Contributor

Motivation

This API call is unnecessary and hinders testing, let's simplify it.

Proposed changes
Use env var instead.

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Check for regressions in acli ide:share

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bc2749) 91.08% compared to head (cf09797) 91.08%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1689   +/-   ##
=========================================
  Coverage     91.08%   91.08%           
- Complexity     1786     1787    +1     
=========================================
  Files           122      122           
  Lines          6368     6368           
=========================================
  Hits           5800     5800           
  Misses          568      568           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell merged commit 11a66fc into acquia:main Feb 21, 2024
14 checks passed
@danepowell danepowell deleted the CLI-1263 branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant