Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1250: Update CXAPI spec to add environments:mod-proxy-status #1699

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Mar 11, 2024

Motivation

Provides access to new commands like environments:mod-proxy-status

Proposed changes

I've hacked the cx api spec to treat date times as string literals. This really needs to be fixed upstream though, it's not sustainable to override it.

Also, while the API now supports hal+json and this makes up the majority of example responses in the spec, we will stick with application/json for actual requests for now and just translate any hal+json responses from the spec to json. At some point we should probably start accepting hal+json (ideally once the ACSF API supports it as well).

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

@danepowell danepowell changed the title CLI-1250: Update CXAPI spec CLI-1250: Update CXAPI spec to add environments:mod-proxy-status Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (2abfc91) to head (9e09c32).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1699      +/-   ##
============================================
- Coverage     91.23%   91.22%   -0.02%     
  Complexity     1794     1794              
============================================
  Files           122      122              
  Lines          6448     6448              
============================================
- Hits           5883     5882       -1     
- Misses          565      566       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell merged commit 0e4cdc1 into acquia:main Mar 12, 2024
11 of 12 checks passed
@danepowell danepowell deleted the CLI-1250 branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant