Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1292: Catch Cloud API type errors #1701

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Mar 13, 2024

@anavarre your opinion on messaging?

Typically a type error does indicate a problem with the application, i.e. some kind of broken configuration or environment. Sometimes it's a more general problem, which is actually true for CLI-1292. There's nothing wrong with the customer application in CLI-1292; the API will pretty much always return cron information that violates the published spec.

@danepowell danepowell added the bug Something isn't working label Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (ec62a12) to head (d62cd5c).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1701   +/-   ##
=========================================
  Coverage     91.22%   91.22%           
- Complexity     1796     1798    +2     
=========================================
  Files           122      122           
  Lines          6450     6452    +2     
=========================================
+ Hits           5884     5886    +2     
  Misses          566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell enabled auto-merge (squash) March 20, 2024 03:07
@danepowell danepowell merged commit 82e821a into acquia:main Mar 20, 2024
12 checks passed
@danepowell danepowell deleted the CLI-1292 branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants