CLI-1293: [api:notifications:find] typeerror for sketchy notification strings #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1705 +/- ##
=========================================
Coverage 91.22% 91.23%
- Complexity 1798 1799 +1
=========================================
Files 122 122
Lines 6452 6455 +3
=========================================
+ Hits 5886 5889 +3
Misses 566 566 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is triggered if the notification string is valid Json but not a response object, i.e.
\"5d811cb4-ac28-4ad2-a002-b0ff726e5040\".Technically this is not supported, but on the off chance that something we told someone to do actually generated that escaped string, we might as well handle it gracefully.