Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1296: auth:login on 2.23.1 > Invalid key in Cloud datastore fixed #1710

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

alchatti
Copy link
Contributor

Motivation
When using the latest version of acli which is 2.23.1 the command auth:login [-k|--key KEY] [-s|--secret SECRET] no longer works and generates the following error. This occurs when acli -n telemetry:disable is set before auth for CI/CD pipelines.

The issue is triggered during CI/CD pipeline by set some settings for the CLI before auth function such as switching on/off the telemetry.

Fixes #1708

Proposed changes
if condition fix, update the cli only.

Alternatives considered
reduce the number of required changes in code

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Disable telemetry acli -n telemetry:disable to create the ~/.acquia/cloud_api.conf
  4. Login using auth:login [-k|--key KEY] [-s|--secret SECRET]
  5. Exception should not be raised and the authentication is a success

@github-actions github-actions bot added the bug Something isn't working label Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (0c453ac) to head (47f2e00).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1710   +/-   ##
=========================================
  Coverage     91.23%   91.23%           
- Complexity     1800     1801    +1     
=========================================
  Files           122      122           
  Lines          6455     6455           
=========================================
  Hits           5889     5889           
  Misses          566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell
Copy link
Contributor

Thanks for the PR! I added some tests.

@danepowell danepowell merged commit 6934108 into acquia:main Mar 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI-1296: auth:login on 2.23.1 > Invalid key in Cloud datastore
2 participants