CLI-1302: [api:applications:environment-create] databases must be array #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1715 +/- ##
============================================
+ Coverage 91.37% 91.40% +0.02%
+ Complexity 1801 1800 -1
============================================
Files 121 121
Lines 6460 6458 -2
============================================
Hits 5903 5903
+ Misses 557 555 -2 ☔ View full report in Codecov by Sentry. |
danepowell
commented
Mar 29, 2024
| // @todo Remove this! It is a workaround for CLI-769. | ||
| elseif ($parameterSpecification['in'] === 'header') { | ||
| $command->addPostParameter($parameterDefinition->getName(), $parameterSpecification); | ||
| } |
There was a problem hiding this comment.
I tested to confirm this is no longer necessary
danepowell
commented
Mar 29, 2024
| @@ -21,7 +21,6 @@ class ApiCommandTest extends CommandTestBase { | |||
|
|
|||
| public function setUp(): void { | |||
| parent::setUp(); | |||
| $this->clientProphecy->addOption('headers', ['Accept' => 'application/json']); | |||
There was a problem hiding this comment.
This is necessary to kill an escaped mutant. We need to check that this method is called, but it isn't actually called on every test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.