Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1294: [auth:logout] warning when key is invalid #1716

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Mar 29, 2024

@anavarre I'm trying to emphasize the self-help instructions for known exceptions by adding a bold "How to fix it" header, since it's otherwise easy to overlook. How do you feel about this?

Screenshot 2024-03-29 at 1 43 08 PM Screenshot 2024-03-29 at 1 44 13 PM

For general exceptions where we can't offer specific help, you get just the second and third sentences about docs and support.

@danepowell danepowell added the bug Something isn't working label Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.41%. Comparing base (72cdee2) to head (86b0ce4).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1716   +/-   ##
=========================================
  Coverage     91.40%   91.41%           
- Complexity     1800     1805    +5     
=========================================
  Files           121      121           
  Lines          6458     6465    +7     
=========================================
+ Hits           5903     5910    +7     
  Misses          555      555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anavarre anavarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. The only thing that I'm unsure of is how it renders with different terminal schemes. I don't see a Phar attached so I can't try it out ATM. Can be dealt with in a different PR as needed.

@danepowell danepowell merged commit 8bb887e into acquia:main Apr 2, 2024
12 checks passed
@danepowell danepowell deleted the CLI-1294 branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants