Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert loopy to static methods #1729

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Convert loopy to static methods #1729

merged 1 commit into from
Apr 17, 2024

Conversation

danepowell
Copy link
Contributor

Solves null pointer exceptions and is generally cleaner

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/0dc9addeda6c62243e1f916bf42ec0a9c7c42897/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/0dc9addeda6c62243e1f916bf42ec0a9c7c42897/acli.phar
chmod +x acli.phar

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.42%. Comparing base (0dc9add) to head (93133c8).

Files Patch % Lines
src/Command/Ssh/SshKeyCommandBase.php 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1729      +/-   ##
============================================
- Coverage     91.42%   91.42%   -0.01%     
  Complexity     1807     1807              
============================================
  Files           121      121              
  Lines          6475     6474       -1     
============================================
- Hits           5920     5919       -1     
  Misses          555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell marked this pull request as ready for review April 17, 2024 21:32
@danepowell danepowell merged commit 7a9469f into acquia:main Apr 17, 2024
15 of 17 checks passed
@danepowell danepowell deleted the loopy branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant