Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1317: api:base is not a valid command #1730

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Apr 18, 2024

For some reason people were actually running this command, and it throws typeerrors that get reported.

We can't make this command abstract in the way we would for the IDE or SSH base command because it gets instantiated dynamically for each API endpoint.

@danepowell danepowell added the bug Something isn't working label Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.46%. Comparing base (cf14e26) to head (8b2c3c7).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1730   +/-   ##
=========================================
  Coverage     91.46%   91.46%           
- Complexity     1808     1809    +1     
=========================================
  Files           121      121           
  Lines          6477     6479    +2     
=========================================
+ Hits           5924     5926    +2     
  Misses          553      553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/cf14e265f4ce838737cd0c0f537e0aa8ff312342/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/cf14e265f4ce838737cd0c0f537e0aa8ff312342/acli.phar
chmod +x acli.phar

@danepowell danepowell marked this pull request as ready for review April 18, 2024 17:59
@danepowell danepowell merged commit b6673f4 into acquia:main Apr 18, 2024
12 checks passed
@anavarre
Copy link
Contributor

Works great.

❯ ./acli.phar api:base

In ApiBaseCommand.php line 92:

  api:base is not a valid command

@danepowell danepowell deleted the CLI-1317 branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants