GL-2530 : PHP 8.3 support for CodeStudio #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1737 +/- ##
=========================================
Coverage 91.64% 91.64%
Complexity 1808 1808
=========================================
Files 121 121
Lines 6474 6475 +1
=========================================
+ Hits 5933 5934 +1
Misses 541 541 ☔ View full report in Codecov by Sentry. |
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1737/acli.phar |
shriacquia
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contain changes to support PHP 8.3 version for
acli cs:wizardcommand for code studio.Testing Steps:
Ran acli cs:wizard command locally and got an option to select php version 8.3
Logged in to code studio UI and check for CI/CD variable for project, PHP_VERSION env variable is being set as 8.3.
