Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1334: TypeError in auth:login #1739

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

danepowell
Copy link
Contributor

Unfortunately validation exceptions occur during container builds and therefore bypass our lovely error handler. Not much we can do about that except to write a whole new error handler just for the container build step.

@danepowell danepowell added the bug Something isn't working label May 17, 2024
Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1739/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1739/acli.phar
chmod +x acli.phar

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (e2b4f21) to head (4c560b2).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1739      +/-   ##
============================================
+ Coverage     91.67%   91.70%   +0.03%     
+ Complexity     1810     1805       -5     
============================================
  Files           121      121              
  Lines          6474     6474              
============================================
+ Hits           5935     5937       +2     
+ Misses          539      537       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell merged commit 1ef1800 into acquia:main May 17, 2024
12 checks passed
@danepowell danepowell deleted the CLI-1334 branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant