Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize ah_env telemetry. #1742

Merged
merged 4 commits into from
May 24, 2024
Merged

Conversation

grasmash
Copy link
Contributor

Motivation

Our ahv_env data has values like ode1, ode37, etc. These should be normalized.

Proposed changes

Normalize ah_env using provided methods from AcquiaDrupalEnvironmentDetector.

@grasmash grasmash added the chore label May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.74%. Comparing base (12e1dc5) to head (d5b33a8).

Files Patch % Lines
src/Helpers/TelemetryHelper.php 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1742      +/-   ##
============================================
+ Coverage     91.73%   91.74%   +0.01%     
- Complexity     1810     1816       +6     
============================================
  Files           121      121              
  Lines          6506     6518      +12     
============================================
+ Hits           5968     5980      +12     
  Misses          538      538              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1742/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1742/acli.phar
chmod +x acli.phar

@grasmash grasmash requested a review from danepowell May 24, 2024 16:01
@danepowell
Copy link
Contributor

This and a lot of the previous PR should really go in the environment detector, but it's not something I have time to handle at the moment.

@danepowell danepowell merged commit ddaf5d7 into acquia:main May 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants