Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL-2753 : CS Wizard updated node version select values #1764

Closed
wants to merge 1 commit into from
Closed

GL-2753 : CS Wizard updated node version select values #1764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Command/CodeStudio/CodeStudioWizardCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@
$phpVersion = $phpVersions[$project];
break;
case "Node_project":
$nodeVersions = [

Check warning on line 62 in src/Command/CodeStudio/CodeStudioWizardCommand.php

View workflow job for this annotation

GitHub Actions / Mutation Testing 

Escaped Mutant for Mutator "ArrayItemRemoval":

--- Original
+++ New
@@ @@
                 $phpVersion = $phpVersions[$project];
                 break;
             case "Node_project":
-                $nodeVersions = ['NODE_version_18' => "18", 'NODE_version_20' => "20"];
+                $nodeVersions = ['NODE_version_20' => "20"];
                 $project = $this->io->choice('Select a NODE version', array_values($nodeVersions), "20");
                 $project = array_search($project, $nodeVersions, TRUE);
                 $nodeVersion = $nodeVersions[$project];
'NODE_version_18.17.1' => "18.17.1",
'NODE_version_20.5.1' => "20.5.1",
'NODE_version_18' => "18",
'NODE_version_20' => "20",
];
$project = $this->io->choice('Select a NODE version', array_values($nodeVersions), "18.17.1");
$project = $this->io->choice('Select a NODE version', array_values($nodeVersions), "20");
$project = array_search($project, $nodeVersions, TRUE);
$nodeVersion = $nodeVersions[$project];
break;
Expand Down
8 changes: 4 additions & 4 deletions tests/phpunit/src/Commands/CodeStudio/CodeStudioWizardCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public function providerTestCommand(): array {
'y',
// Select a project type Node_project.
'1',
// Select NODE version 18.17.1.
// Select NODE version 18.
'0',
// Do you want to continue?
'y',
Expand All @@ -163,7 +163,7 @@ public function providerTestCommand(): array {
'y',
// Select a project type Node_project.
'1',
// Select NODE version 20.5.1.
// Select NODE version 20.
'1',
// Do you want to continue?
'y',
Expand Down Expand Up @@ -228,7 +228,7 @@ public function providerTestCommand(): array {
$this->secret,
// Select a project type Node_project.
'1',
// Select NODE version 18.17.1.
// Select NODE version 18.
'0',
// Do you want to continue?
'y',
Expand Down Expand Up @@ -270,7 +270,7 @@ public function providerTestCommand(): array {
$this->secret,
// Select a project type Node_project.
'1',
// Select NODE version 20.5.1.
// Select NODE version 20.
'1',
// Do you want to continue?
'y',
Expand Down
Loading