-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI-979: Consolidate update-check logic #1774
Conversation
I've added caching to the self-update library and created a new ticket to poll less often in the first place. Just need to get tests passing now. |
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1774/acli.phar
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1774 +/- ##
============================================
+ Coverage 92.02% 92.21% +0.19%
+ Complexity 1826 1817 -9
============================================
Files 121 121
Lines 6844 6811 -33
============================================
- Hits 6298 6281 -17
+ Misses 546 530 -16 ☔ View full report in Codecov by Sentry. |
Fix #1403
Waiting on consolidation/self-update#34