Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-979: Consolidate update-check logic #1774

Merged
merged 12 commits into from
Aug 27, 2024
Merged

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Jul 26, 2024

Fix #1403

Waiting on consolidation/self-update#34

@danepowell
Copy link
Contributor Author

I've added caching to the self-update library and created a new ticket to poll less often in the first place.

Just need to get tests passing now.

Copy link

github-actions bot commented Aug 8, 2024

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1774/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1774/acli.phar
chmod +x acli.phar

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (402fbef) to head (62b8e53).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1774      +/-   ##
============================================
+ Coverage     92.02%   92.21%   +0.19%     
+ Complexity     1826     1817       -9     
============================================
  Files           121      121              
  Lines          6844     6811      -33     
============================================
- Hits           6298     6281      -17     
+ Misses          546      530      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell marked this pull request as ready for review August 27, 2024 17:42
@danepowell danepowell merged commit a700f92 into acquia:main Aug 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI-979: Consolidate update-check logic
1 participant