Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL-3134: Add new Gitlab variable for Node projects. #1818

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

bemarlan
Copy link
Contributor

Motivation

Fixes GL-3134

Proposed changes

New Node.js projects created in Code Studio pass a new variable of NODE_HOSTING_TYPE with a default value of basic. When Node V3 launches, we will update the user prompts to ask for a Node hosting type.

Alternatives considered

N/A

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Run acli cs:wizard --gitlab-host-name=code.dev.cloudservices.acquia.io (or other env as needed)
  4. Select prompts for a Node.js application
  5. Confirm you do not see a prompt for Node hosting type
  6. When the project is created in Gitlab, an environment variable should exist for NODE_HOSTING_TYPE with a value of basic. Variable should not be protected or masked.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (befc2dc) to head (bcc866e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1818   +/-   ##
=========================================
  Coverage     92.55%   92.56%           
  Complexity     1830     1830           
=========================================
  Files           123      123           
  Lines          6929     6937    +8     
=========================================
+ Hits           6413     6421    +8     
  Misses          516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1818/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1818/acli.phar
chmod +x acli.phar

@danepowell danepowell merged commit 59fe530 into acquia:main Oct 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants