Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1396: [app:new:local] Add project template option #1838

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Dec 6, 2024

Motivation

Fixes CLI-1396

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. If running from source, clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Check for regressions: (add specific steps for this pr)
  4. Check new functionality: (add specific steps for this pr)

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (94fa98e) to head (f491b10).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1838   +/-   ##
=========================================
  Coverage     92.91%   92.91%           
- Complexity     1843     1845    +2     
=========================================
  Files           123      123           
  Lines          6960     6960           
=========================================
  Hits           6467     6467           
  Misses          493      493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 6, 2024

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1838/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1838/acli.phar
chmod +x acli.phar

@danepowell danepowell requested a review from eporama December 6, 2024 22:51
@danepowell
Copy link
Contributor Author

@eporama would you like a chance to review this? My only question is whether to take a machine name (acquia_drupal_recommended) or composer name (acquia/drupal-recommended-project) as an option. The machine name doesn't contain special characters and is less likely to cause problems in scripts but is obviously less intuitive. Symfony should give you suggestions but I can't test this in the dev release.

@danepowell danepowell marked this pull request as ready for review December 12, 2024 19:10
@danepowell danepowell merged commit 2232593 into acquia:main Dec 12, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant