Race-safe LoggingParams #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alternativehood
force-pushed
the
master
branch
3 times, most recently
from
2cd1a5c to
7379296
Compare
vasayxtx
reviewed
Feb 17, 2025
httpclient/logging_round_tripper.go
Outdated
| @@ -96,6 +96,7 @@ func (rt *LoggingRoundTripper) getLogger(ctx context.Context) log.FieldLogger { | |||
| } | |||
|
|
|||
| // RoundTrip adds logging capabilities to the HTTP transport. | |||
| // Notice - external_request time is cumulative and will not be accurate if multiple concurrent requests are done | |||
There was a problem hiding this comment.
Could you please elaborate on what the external_request time represents and clarify its connection to middleware.LoggingParams? This additional context would help clarify its purpose.
alternativehood
force-pushed
the
master
branch
from
7379296 to
805926b
Compare
alternativehood
force-pushed
the
master
branch
from
805926b to
ed7f180
Compare
vasayxtx
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.