Remove gojwk package #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasayxtx
reviewed
Feb 26, 2025
vasayxtx
reviewed
Feb 26, 2025
vasayxtx
reviewed
Feb 26, 2025
vasayxtx
reviewed
Feb 26, 2025
vasayxtx
reviewed
Feb 26, 2025
akhromium
force-pushed
the
remove_gojwk
branch
from
ab25121 to
0d951a9
Compare
vasayxtx
reviewed
Mar 5, 2025
|
|
||
| // DecodePublicKey decodes Key to public key. | ||
| func (j *Key) DecodePublicKey() (crypto.PublicKey, error) { | ||
| if _, ok := supportedKeyTypes[j.Kty]; !ok { |
There was a problem hiding this comment.
Just a minor suggestion: I’m not sure if we need a separate supportedKeyTypes map. Returning an error in the end of the func should be sufficient. Otherwise, we’d need to constantly remember to keep the map updated.
There was a problem hiding this comment.
This was done for the future support of EC or other Key types.
There was a problem hiding this comment.
My point is we can simplify this and have code something like
switch j.Kty {
case "RSA":
// handle RSA key
case "EC":
// handle ecliptic curve key
default:
return nil, fmt.Errorf("unsupported key type %s", j.Kty)
}There was a problem hiding this comment.
Agreed to improve with the next iteration
akhromium
force-pushed
the
remove_gojwk
branch
2 times, most recently
from
16d5dab to
55a1fba
Compare
vasayxtx
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in PM. Part of the dependencies update activity.