Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svm): web3 v2, codama clients, and events retrieval #866

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,5 @@ target
test-ledger
idls
src/svm/assets
src/svm/clients/*
!src/svm/clients/index.ts
7 changes: 6 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
"lint-fix": "yarn prettier --write **/*.js **/*.ts ./programs/**/*.rs ./contracts**/*.sol && cargo +nightly fmt --all && cargo clippy",
"clean-fast": "for dir in node_modules cache cache-zk artifacts artifacts-zk dist typechain; do mv \"${dir}\" \"_${dir}\"; rm -rf \"_${dir}\" &; done",
"clean": "rm -rf node_modules cache cache-zk artifacts artifacts-zk dist typechain",
"generate-svm-assets": "sh ./scripts/generate-svm-assets.sh",
"generate-svm-assets": "sh ./scripts/generate-svm-assets.sh && yarn generate-svm-clients",
"generate-svm-clients": "yarn ts-node ./scripts/svm/utils/generate-svm-clients.ts && yarn ts-node ./scripts/svm/utils/rename-clients-imports.ts",
"build-evm": "hardhat compile",
"build-svm": "echo 'Generating IDLs...' && anchor build > /dev/null 2>&1 || true && anchor run generateExternalTypes && anchor build",
"build-ts": "tsc && rsync -a --include '*/' --include '*.d.ts' --exclude '*' ./typechain ./dist/",
Expand Down Expand Up @@ -54,6 +55,7 @@
"@solana-developers/helpers": "^2.4.0",
"@solana/spl-token": "^0.4.6",
"@solana/web3.js": "^1.31.0",
"@solana/web3-v2.js": "npm:@solana/web3.js@2",
"@types/yargs": "^17.0.33",
"@uma/common": "^2.37.3",
"@uma/contracts-node": "^0.4.17",
Expand All @@ -65,6 +67,9 @@
"zksync-web3": "^0.14.3"
},
"devDependencies": {
"@codama/nodes-from-anchor": "^1.1.0",
"@codama/renderers-js": "^1.1.1",
"codama": "^1.2.0",
"@consensys/linea-sdk": "^0.1.6",
"@matterlabs/hardhat-zksync-deploy": "^0.6.3",
"@matterlabs/hardhat-zksync-solc": "^1.1.4",
Expand Down
24 changes: 24 additions & 0 deletions scripts/svm/utils/generate-svm-clients.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { createFromRoot } from "codama";
import { rootNodeFromAnchor, AnchorIdl } from "@codama/nodes-from-anchor";
import { renderVisitor as renderJavaScriptVisitor } from "@codama/renderers-js";
import { SvmSpokeIdl, MulticallHandlerIdl } from "../../../src/svm/assets";
import path from "path";
export const clientsPath = path.join(__dirname, "..", "..", "..", "src", "svm", "clients");

// Generate SvmSpoke clients
let codama = createFromRoot(rootNodeFromAnchor(SvmSpokeIdl as AnchorIdl));
codama.accept(renderJavaScriptVisitor(path.join(clientsPath, "SvmSpoke")));

// Generate MulticallHandler clients
codama = createFromRoot(rootNodeFromAnchor(MulticallHandlerIdl as AnchorIdl));
codama.accept(renderJavaScriptVisitor(path.join(clientsPath, "MulticallHandler")));

// codama = createFromRoot(rootNodeFromAnchor(MessageTransmitterIdl as AnchorIdl));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending to fix.

// codama.accept(
// renderJavaScriptVisitor(path.join(clientsPath, "MessageTransmitter"))
// );

// codama = createFromRoot(rootNodeFromAnchor(TokenMessengerMinterIdl as AnchorIdl));
// codama.accept(
// renderJavaScriptVisitor(path.join(clientsPath, "TokenMessengerMinter"))
// );
22 changes: 22 additions & 0 deletions scripts/svm/utils/rename-clients-imports.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
const fs = require("fs");
const path = require("path");

const clientsPath = path.join(__dirname, "..", "..", "..", "src", "svm", "clients");

function replaceInFiles(dir: string): void {
const files = fs.readdirSync(dir);
files.forEach((file: string) => {
const filePath = path.join(dir, file);
const stat = fs.statSync(filePath);

if (stat.isDirectory()) {
replaceInFiles(filePath);
} else if (file.endsWith(".ts")) {
const fileContent = fs.readFileSync(filePath, "utf8");
const updatedContent = fileContent.replace("@solana/web3.js", "@solana/web3-v2.js");
fs.writeFileSync(filePath, updatedContent);
}
});
}

replaceInFiles(clientsPath);
4 changes: 4 additions & 0 deletions src/svm/clients/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import * as MulticallHandlerClient from "./MulticallHandler";
import * as SvmSpokeClient from "./SvmSpoke";

export { MulticallHandlerClient, SvmSpokeClient };
12 changes: 2 additions & 10 deletions src/svm/index.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
export * from "./relayHashUtils";
export * from "./instructionParamsUtils";
export * from "./conversionUtils";
export * from "./transactionUtils";
export * from "./solanaProgramUtils";
export * from "./coders";
export * from "./programConnectors";
export * from "./web3-v1";
export * from "./assets";
export * from "./constants";
export * from "./helpers";
export * from "./cctpHelpers";
export * from "./clients";
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as anchor from "@coral-xyz/anchor";
import { array, object, optional, string, Struct } from "superstruct";
import { readUInt256BE } from "../../src/svm";
import { readUInt256BE } from "./relayHashUtils";

// Index positions to decode Message Header from
// https://developers.circle.com/stablecoins/docs/message-format#message-header
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
10 changes: 10 additions & 0 deletions src/svm/web3-v1/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
export * from "./relayHashUtils";
export * from "./instructionParamsUtils";
export * from "./conversionUtils";
export * from "./transactionUtils";
export * from "./solanaProgramUtils";
export * from "./coders";
export * from "./programConnectors";
export * from "./constants";
export * from "./helpers";
export * from "./cctpHelpers";
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
130 changes: 130 additions & 0 deletions src/svm/web3-v2/solanaProgramUtils.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
import { BorshEventCoder, Idl, utils } from "@coral-xyz/anchor";
import web3, {
Address,
Commitment,
GetTransactionApi,
Signature,
Slot,
TransactionError,
UnixTimestamp,
} from "@solana/web3-v2.js";

type GetTransactionReturnType = ReturnType<GetTransactionApi["getTransaction"]>;

type GetSignaturesForAddressConfig = Readonly<{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe can infer this type without replicating upstream:

type GetSignaturesForAddressConfig = Parameters<GetSignaturesForAddressApi["getSignaturesForAddress"]>[1]

before?: Signature;
commitment?: Exclude<Commitment, "processed">;
limit?: number;
minContextSlot?: Slot;
until?: Signature;
}>;

type GetSignaturesForAddressTransaction = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe can also infer this:

type GetSignaturesForAddressTransaction = ReturnType<GetSignaturesForAddressApi["getSignaturesForAddress"]>[number];

blockTime: UnixTimestamp | null;
confirmationStatus: Commitment | null;
err: TransactionError | null;
memo: string | null;
signature: Signature;
slot: Slot;
};

/**
* Reads all events for a specific program.
*/
export async function readProgramEvents(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you test this?

rpc: web3.Rpc<web3.SolanaRpcApiFromTransport<any>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe replace any with RpcTransport?

program: Address,
anchorIdl: Idl,
finality: Commitment = "confirmed",
options: GetSignaturesForAddressConfig = { limit: 1000 }
) {
const allSignatures: GetSignaturesForAddressTransaction[] = [];

// Fetch all signatures in sequential batches
while (true) {
const signatures = await rpc.getSignaturesForAddress(program, options).send();
allSignatures.push(...signatures);

// Update options for the next batch. Set before to the last fetched signature.
if (signatures.length > 0) {
options = { ...options, before: signatures[signatures.length - 1].signature };
}

if (options.limit && signatures.length < options.limit) break; // Exit early if the number of signatures < limit
}

// Fetch events for all signatures in parallel
const eventsWithSlots = await Promise.all(
allSignatures.map(async (signatureTransaction) => {
const events = await readEvents(rpc, signatureTransaction.signature, program, anchorIdl, finality);

return events.map((event) => ({
...event,
confirmationStatus: signatureTransaction.confirmationStatus || "Unknown",
blockTime: signatureTransaction.blockTime || 0,
signature: signatureTransaction.signature,
slot: signatureTransaction.slot,
name: event.name || "Unknown",
}));
})
);
return eventsWithSlots.flat();
}

/**
* Reads events from a transaction.
*/
export async function readEvents(
rpc: web3.Rpc<web3.SolanaRpcApiFromTransport<any>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe replace any with RpcTransport?

txSignature: Signature,
programId: Address,
programIdl: Idl,
commitment: Commitment = "confirmed"
) {
const txResult = await rpc.getTransaction(txSignature, { commitment, maxSupportedTransactionVersion: 0 }).send();

if (txResult === null) return [];

return processEventFromTx(txResult, programId, programIdl);
}

/**
* Processes events from a transaction.
*/
async function processEventFromTx(
txResult: GetTransactionReturnType,
programId: Address,
programIdl: Idl
): Promise<{ program: Address; data: any; name: string | undefined }[]> {
if (!txResult) return [];
const eventAuthorities: Map<string, Address> = new Map();
const events: { program: Address; data: any; name: string | undefined }[] = [];
const [pda] = await web3.getProgramDerivedAddress({ programAddress: programId, seeds: ["__event_authority"] });
eventAuthorities.set(programId, pda);

const messageAccountKeys = txResult.transaction.message.accountKeys;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tested this with V0 transactions? does accountKeys also include loaded addresses from ALTs in web3-v2?


for (const ixBlock of txResult.meta?.innerInstructions ?? []) {
for (const ix of ixBlock.instructions) {
const ixProgramId = messageAccountKeys[ix.programIdIndex];
const singleIxAccount = ix.accounts.length === 1 ? messageAccountKeys[ix.accounts[0]] : undefined;
if (
ixProgramId !== undefined &&
singleIxAccount !== undefined &&
programId == ixProgramId &&
eventAuthorities.get(ixProgramId.toString()) == singleIxAccount
) {
const ixData = utils.bytes.bs58.decode(ix.data);
const eventData = utils.bytes.base64.encode(Buffer.from(new Uint8Array(ixData).slice(8)));
let event = new BorshEventCoder(programIdl).decode(eventData);
events.push({
program: programId,
data: event?.data,
name: event?.name,
});
}
}
}

return events;
}
Loading
Loading