Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Audio or video element avoids automatically playing audio" [80f0bf]: Add Accessibility Support note about autoplay not being respected #2076

Merged
merged 13 commits into from
Feb 15, 2024

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Jun 22, 2023

Make 1.4.2 as secondary requirement since autoplay is not always respected depending on user engagement with the page.
See https://www.w3.org/2023/04/13-act-r-minutes.html#item09

Closes issue(s):

Need for Call for Review:
This will require a 1 weeks Call for Review (adding a non-normative note)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Jun 22, 2023
@Jym77 Jym77 self-assigned this Jun 22, 2023
@Jym77
Copy link
Collaborator Author

Jym77 commented Jun 22, 2023

Note: will need to be updated once #2060 is merged.

@Jym77 Jym77 requested a review from tbostic32 July 13, 2023 08:19
@WilcoFiers WilcoFiers requested a review from kengdoj July 20, 2023 13:49
tbostic32
tbostic32 previously approved these changes Aug 3, 2023
Copy link
Collaborator

@kengdoj kengdoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #2095 (comment)

@Jym77
Copy link
Collaborator Author

Jym77 commented Sep 28, 2023

@kengdoj @tbostic32 I've reverted to primary requirement, following #2095, and kept the (new) AS note.

@Jym77 Jym77 requested a review from kengdoj September 28, 2023 12:42
@Jym77 Jym77 dismissed tbostic32’s stale review September 28, 2023 12:43

Reverted to primary requirement.

@WilcoFiers
Copy link
Member

@Jym77 I think we decided we were not going to do this. Can this PR be closed?

@Jym77 Jym77 changed the title "Audio or video element avoids automatically playing audio" [80f0bf]: Move 1.4.2 as secondary requirement "Audio or video element avoids automatically playing audio" [80f0bf]: Add Accessibility Support note about autoplay not being respected Oct 12, 2023
@Jym77
Copy link
Collaborator Author

Jym77 commented Oct 12, 2023

@WilcoFiers Ah yes, this was actually reduced to adding an Accessibility Support note 😅
I've updated the title.

@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 1, 2024

Call for Review ends on February 8th.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Feb 1, 2024
@Jym77
Copy link
Collaborator Author

Jym77 commented Feb 15, 2024

Call for Review has ended. Merging.

@Jym77 Jym77 merged commit c1ecd49 into develop Feb 15, 2024
2 checks passed
@Jym77 Jym77 deleted the autoplay-secondary branch February 15, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoplay rule [x0paj4] failed examples don't autoplay in major browsers
6 participants