Fix too many calendars on Android #2503
Open
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnunicorn
added
the
merge post release only
gnunicorn
added
s-calendar
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2503 +/- ##
=======================================
Coverage 27.32% 27.32%
=======================================
Files 680 680
Lines 44523 44523
=======================================
+ Hits 12165 12168 +3
+ Misses 32358 32355 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logs of https://github.com/acterglobal/a3-meta/issues/709 showed that despite our local cached info being retrieved properly, the calendars were not found and instead a new one was created:
As if the call for
retrieveCalendarswasn't working at all. Checking the documentation of the plugin, we can see that there is a section about if exactly that kind of problem, which I ignored in the past, as we didn't have configured. But revisiting this, it seems that this is exactly the issue causing #2369 and also explaining why all is fine in debug mode and we only see it on nightly and release:This PR applies those changes (and a minor more verbose trace) so we can try it out in a nightly release (after this release) and confirm the fix.