Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost Action : Share Link #2536

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Boost Action : Share Link #2536

merged 7 commits into from
Jan 31, 2025

Conversation

kumarpalsinh25
Copy link
Contributor

@kumarpalsinh25 kumarpalsinh25 commented Jan 30, 2025

Fixes, #2538

Adding Link Action support in Boost.

Screen.Recording.2025-01-30.at.7.58.56.PM.mov

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.64%. Comparing base (47cdbc6) to head (4cb407d).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
native/acter/src/api/deep_linking.rs 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2536      +/-   ##
==========================================
+ Coverage   30.36%   30.64%   +0.27%     
==========================================
  Files         710      715       +5     
  Lines       46889    47075     +186     
==========================================
+ Hits        14239    14424     +185     
- Misses      32650    32651       +1     
Flag Coverage Δ
integration-test 40.26% <37.50%> (+0.46%) ⬆️
unittest 22.44% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kumarpalsinh25 kumarpalsinh25 marked this pull request as ready for review January 30, 2025 14:33
@kumarpalsinh25 kumarpalsinh25 requested review from gnunicorn and gtalha07 and removed request for gnunicorn January 30, 2025 14:47
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor UI change

@kumarpalsinh25
Copy link
Contributor Author

@gnunicorn
Thanks for quick review.

I have addressed minor suggestion related UI and pushed the commit.

Can you help me with resolution of Rust Test failure so that I can merge this PR?

@gnunicorn
Copy link
Contributor

Can you help me with resolution of Rust Test failure so that I can merge this PR?

I had committed and pushed the fix, but then you force pushed your changes, removing my fix :p .

@kumarpalsinh25 kumarpalsinh25 merged commit 0422b19 into main Jan 31, 2025
23 checks passed
@kumarpalsinh25 kumarpalsinh25 deleted the kumar/boost-actions branch January 31, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Recently Done
Development

Successfully merging this pull request may close these issues.

2 participants