Implement rust notifications for creation, title and description change of major objects #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnunicorn
added
rust
f-push-notifications
|
Hey there 👋,
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2539 +/- ##
==========================================
+ Coverage 30.61% 31.17% +0.55%
==========================================
Files 714 714
Lines 47017 47202 +185
==========================================
+ Hits 14393 14713 +320
+ Misses 32624 32489 -135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ comes with tests.
Implements the basic starter notifications of "creation" and change of title and description for the main types Pin, CalendarEvent & TaskList. Tests are mostly copy-paste but ensure that all these work fine and according to spec modeled in #2517 .
This is a first set, split out into a separate PR to make reviewing easier. Further types will be added on top. Also contains a few tests for redaction, attachments and references that are disabled for now as these are not yet implemented.