This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this change will enable GitHub to correctly display the annotations in-line when using a
Cargo.toml
that is not in the project root.manifest-path:
option to the actionmanifest-path
is specified, inserts--manifest-path <value>
into the clippy args listmanifest-path
is specified, the generated annotations get the filename prefixed with the parent of the file specified viamanifest-path:
.Addresses #28.
Note: I have not (yet) built the
dist/index.js
(because I couldn't figure out how!).I couldn't get it to build locally with the existing package.json due to inability to find
@actions-rs/core="0.1.3"
on npm. I was able to get it to build locally using a local clone, but then I couldn't get to actually work in my own github actions (presumably due to doing something wrong during the build).I'm relatively inexperienced with npm, typescript, and github actions, so would appreciate any help getting this over the line. (Or an answer to #28)