Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cached licenses and added package-lock #26

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

JeroenKnoops
Copy link
Contributor

Problem

Since the package-lock.json is missing, you're not sure what dependencies are used.
This will result in a mismatch in the cached licenses and the actual licenses.

This results in a failing licenses workflow, see issue #25

Solution

  • Add package-lock.json
  • Update cached licenses

Related issues

Closes #3, #25

@rodrigoargumedo
Copy link

rodrigoargumedo commented Oct 27, 2020

@JeroenKnoops I think adding RUN npm install -g [email protected] or RUN npm install -g npm@latest to the dockerfile should resolve this problem.

@JeroenKnoops
Copy link
Contributor Author

@JeroenKnoops I think adding RUN npm install -g [email protected] or RUN npm install -g npm@latest to the dockerfile should resolve this problem.

Using @latest can result in the same type of errors in the future.. I would advise against that.

The reason the license check fails is because the cached license files are not matching the actual used dependencies.

I recommend either removing the license check with cached licenses yml files, or use a package-lock.json to make sure the dependencies are pinned.

@dakale
Copy link
Contributor

dakale commented Oct 27, 2020

LGTM, thanks @JeroenKnoops!

@dakale dakale merged commit fd47e65 into actions:main Oct 27, 2020
dakale pushed a commit that referenced this pull request Oct 27, 2020
dakale pushed a commit that referenced this pull request Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning missing package-lock.json file.
3 participants