-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ManagedDB] Rest API based Thin client for ManagedService #2666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Kudos, SonarCloud Quality Gate passed! |
adolkhan
force-pushed
the
managed-thin-client
branch
from
November 9, 2023 12:34
9d68bb9
to
de04c28
Compare
…e into managed-thin-client
AdkSarsen
force-pushed
the
managed-thin-client
branch
from
December 28, 2023 19:28
0763abf
to
c0a76dd
Compare
…e into managed-thin-client
…e into managed-thin-client
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Impact
Description
Creating a thin Rest-API client that communicates with the ManagedService.
Main idea, is that most computations shall happen not on client side, and the wrapper should only handle the communication part, with nice and intuitive wrappers, replicating regular VectorStore Interface.
Things to be aware of
Current version excludes the ability of the user to pass any functions / UDFs. Therefore
embedding_function
andfilter
parameters will throwNotImplementedError
, if passed.filter
only supports a dictionary.Things to worry about
Additional Context