addon-updaterの更新 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitabatake1013
requested changes
Feb 17, 2025
addon/globalPlugins/ERE/updater.py
Outdated
| if isCompatibleWith2025(): | ||
| return gui.message.MessageDialog.confirm(message, title) == gui.message.ReturnCode.OK | ||
| else: | ||
| return gui.messageBox(message, title, style=wx.CENTER | wx.OK | wx.CANCEL | wx.ICON_INFORMATION) == wx.ID_OK |
There was a problem hiding this comment.
gui.messageBox()の戻り値は、wx.ID_OKではなくwx.OKのようです。
There was a problem hiding this comment.
The return value is one of: YES , NO , CANCEL , OK or HELP (notice that this return value is different from the return value of wx.MessageDialog.ShowModal ).
ほんまや
addon/globalPlugins/ERE/updater.py
Outdated
| _("The update information is invalid.\nPlease contact ACT Laboratory for further information."), | ||
| _("Error"), | ||
| style=wx.CENTER | wx.ICON_WARNING) | ||
| gui.messageBox(strs.ERROR_UPDATE_INFO_INVALID, strs.ERROR) |
There was a problem hiding this comment.
messageBox(strs.ERROR_UPDATE_INFO_INVALID, strs.ERROR)
ではないでしょうか。
kitabatake1013
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
このPRでやっていること
やってもらいたいこと
以下の確認をお願いします
私はとりあえず全部のアドオンにワールドツアーして回るので、動作確認は、アドオンを主担当した人にお願いしたいです。
実際にアップデートできるまでテストしてもらえると助かります。ローカルだけバージョン番号を下げることでテストできると思います。