Skip to content

Commit

Permalink
pin numpy version to 1.18.5 (pytorch#42670)
Browse files Browse the repository at this point in the history
Summary:
Using numpy 1.19.x instead of 1.18.x breaks certain unit tests.
Fixes pytorch#42561.  Likely also fixes pytorch#42583.

CC ezyang xw285cornell sunway513

Pull Request resolved: pytorch#42670

Reviewed By: ezyang

Differential Revision: D22978369

Pulled By: malfet

fbshipit-source-id: ce1f35c7ba620c2b9dd10613f39354cebee8b87d
  • Loading branch information
jeffdaily authored and facebook-github-bot committed Aug 6, 2020
1 parent bcab2d6 commit 049c1b9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .circleci/docker/common/install_conda.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ if [ -n "$ANACONDA_PYTHON_VERSION" ]; then
if [ "$ANACONDA_PYTHON_VERSION" = "3.8" ]; then
# DO NOT install typing if installing python-3.8, since its part of python-3.8 core packages
# Install llvm-8 as it is required to compile llvmlite-0.30.0 from source
conda_install numpy pyyaml mkl mkl-include setuptools cffi future six llvmdev=8.0.0
conda_install numpy=1.18.5 pyyaml mkl mkl-include setuptools cffi future six llvmdev=8.0.0
else
conda_install numpy pyyaml mkl mkl-include setuptools cffi typing future six
conda_install numpy=1.18.5 pyyaml mkl mkl-include setuptools cffi typing future six
fi
if [[ "$CUDA_VERSION" == 9.2* ]]; then
conda_install magma-cuda92 -c pytorch
Expand Down
2 changes: 1 addition & 1 deletion docker/caffe2/jenkins/common/install_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ pip install --no-cache-dir \
future \
hypothesis \
jupyter \
numpy \
numpy==1.18.5 \
protobuf \
pytest \
pyyaml \
Expand Down

0 comments on commit 049c1b9

Please sign in to comment.