-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print the source_location
on missed timeout checks.
#1254
Print the source_location
on missed timeout checks.
#1254
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1254 +/- ##
==========================================
- Coverage 87.52% 87.50% -0.02%
==========================================
Files 308 308
Lines 27909 27917 +8
Branches 3122 3125 +3
==========================================
+ Hits 24426 24430 +4
- Misses 2346 2350 +4
Partials 1137 1137 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice,
I only have a few remarks which shouldn't be hard to fix.
|
CancellationHandle
interface so source_location is used instead of developer-defined stringsource_location
on missed timeout checks.
When QLever detects that there was no check for a timeout for too long, the log now prints the location (filename and line number) where the missing check was detected. This will make it easier to debug these missed checks.