Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the source_location on missed timeout checks. #1254

Merged
merged 11 commits into from
Feb 6, 2024

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Jan 31, 2024

When QLever detects that there was no check for a timeout for too long, the log now prints the location (filename and line number) where the missing check was detected. This will make it easier to debug these missed checks.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (ac9db29) 87.52% compared to head (7349bdf) 87.50%.

Files Patch % Lines
src/engine/QueryPlanner.cpp 78.57% 3 Missing ⚠️
src/engine/RuntimeInformation.cpp 0.00% 1 Missing and 1 partial ⚠️
src/engine/Operation.cpp 87.50% 0 Missing and 1 partial ⚠️
...c/engine/sparqlExpressions/GroupConcatExpression.h 50.00% 1 Missing ⚠️
src/index/CompressedRelation.cpp 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
- Coverage   87.52%   87.50%   -0.02%     
==========================================
  Files         308      308              
  Lines       27909    27917       +8     
  Branches     3122     3125       +3     
==========================================
+ Hits        24426    24430       +4     
- Misses       2346     2350       +4     
  Partials     1137     1137              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice,
I only have a few remarks which shouldn't be hard to fix.

src/engine/Operation.cpp Show resolved Hide resolved
src/util/CancellationHandle.h Outdated Show resolved Hide resolved
src/util/CancellationHandle.h Outdated Show resolved Hide resolved
src/util/CancellationHandle.h Outdated Show resolved Hide resolved
src/util/CancellationHandle.h Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Feb 4, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@joka921 joka921 changed the title Change the CancellationHandle interface so source_location is used instead of developer-defined string Print the source_location on missed timeout checks. Feb 6, 2024
@joka921 joka921 merged commit ea9d258 into ad-freiburg:master Feb 6, 2024
17 of 18 checks passed
@RobinTF RobinTF deleted the automate-detail-reporting branch February 6, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants