Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also store the actual query alongside its ID. #1256

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Jan 31, 2024

The request that dumps all active queries (if given the correct access token) now also dumps the queries and not only their internal QueryIds.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea905cc) 87.46% compared to head (40e1b43) 87.52%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1256      +/-   ##
==========================================
+ Coverage   87.46%   87.52%   +0.05%     
==========================================
  Files         307      308       +1     
  Lines       27771    27907     +136     
  Branches     3116     3122       +6     
==========================================
+ Hits        24291    24425     +134     
  Misses       2346     2346              
- Partials     1134     1136       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only very minor changes.

src/util/http/websocket/QueryId.h Show resolved Hide resolved
src/util/http/websocket/QueryId.h Outdated Show resolved Hide resolved
src/engine/Server.cpp Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@joka921 joka921 changed the title Store query inside query registry for nicer debugging purposes Also store the actual query alongside its ID. Feb 6, 2024
@joka921 joka921 merged commit c036cde into ad-freiburg:master Feb 6, 2024
18 checks passed
@RobinTF RobinTF deleted the better-active-query-dump branch February 6, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants